search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 413 forks source link

search filters options partially broken #3660

Closed 8bitbunny closed 3 years ago

8bitbunny commented 4 years ago

Bug when i tried to use the search option a bit ago, i got to encounter a search bug with file types: it only being applied when i search cor content only, where it does not apply when i search for 'all' with for example only having selected media type "audio ", which still shows other types of content

To Reproduce 1) go to search on desktop app 2) search for a term (i used corona in my case) 3) open search filters 4) set searching for to everything (so not just users or content, but both) 5) set filetype to something else than all checkboxes (i tried only filtering by audio) 6) see the behaviour as linked in my screen from discord in screen1

Expected behavior the search should be like the screen2 in screenshots, but the issue relies in the topmost option row it seems

some translation for the screenshots provided in case of needed: zoeken naar = search for bestanden / kanalen / alles = files / channels / everything(all)

Screenshots screen1: https://cdn.discordapp.com/attachments/363087331475062785/675854179725606962/unknown.png screen2: https://cdn.discordapp.com/attachments/363087331475062785/675854382755086366/unknown.png

System Configuration deamon 0.54.1 app 0.41.0 os version: windows 10 x64

Additional context small tip for a more stremlined search: making one filter section, thus merging the current 2 ones to: search for: users, video, audio, pictures, text, other, downloads, your content.

yours, ramon.

tzarebczan commented 4 years ago

Nice find, thank you! Looks like we don't pass them when the everything option is used, so they should be greyed out (when channels option is chosen also).

tzarebczan commented 3 years ago

This recently came up as a source of confusion. We should hide or grey out those options on the search page.

Ruk33 commented 3 years ago

Thanks for the details in the bug report, it really helps! Will be working on it.

Ruk33 commented 3 years ago

Confirmed, the type parameter (mediaType) isn't being sent when using everything.

Ruk33 commented 3 years ago

There we go https://github.com/lbryio/lbry-desktop/pull/5516. Regards.

tzarebczan commented 3 years ago

This is now fixed.