search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 414 forks source link

Flatpak version open another process even if it's already running #3898

Closed REIS0 closed 4 years ago

REIS0 commented 4 years ago

Bug lbry desktop loads another instance even though is already running

image

image

To Reproduce Steps to reproduce the behavior:

  1. Open lbry
  2. Close
  3. Open lbry lauching from other source besides the system tray
  4. Now there's two lbry process running

Expected behavior To open the already running lbry

System Configuration

tzarebczan commented 4 years ago

Thanks for opening the issue! Do you know how this normally works for flatpak apps? Maybe @kcseb can take a closer look?

REIS0 commented 4 years ago

sorry i really don't know, i'm using other flatpaks, discord and slack for example, and i've never seen this happening

REIS0 commented 4 years ago

just to add that i've used to .deb version before and so far this doesn't happen

kcseb commented 4 years ago

Will take a look at this in a short bit. Will try it out on both a fresh install, and existing install.

kcseb commented 4 years ago

Can confirm that this indeed happens. When you run the Flatpak version via command-line, then spawn another instance, that secondary instance does not check to see if any others exist.

However, a warning is thrown from lbrynet ittself; "SDK already running Server already listening at localhost:5278. This is probably another LBRY app running. If not, games in the app will not work."

You mention being on PopOS? @REIS0 - Correct me if I am wrong, but that distribution is based on Debian? Or at the very least makes use of aptitude?

I'd highly suggest running the .deb as you were before rather than Flatpak.

I don't really know if Flatpak checks for existing spawns of any given application. That might be a question for the Flatpak folks themselves. I can tell you that this doesn't happen on the AUR version, either... So it seems to be attributed solely to the Flatpak version.

REIS0 commented 4 years ago

@kcseb Is based on ubuntu, so i'll use the .deb version then

what is strange is that lbry is the only program that this happens actually, never saw something like that with other flatpaks

kcseb commented 4 years ago

I think it's a one-off issue with this package specifically. I'll look into adding a check for existing processes on startup.

For now, if you could, post an issue on the Flathub repository. Thank you!

https://github.com/flathub/io.lbry.lbry-app https://github.com/flathub/io.lbry.lbry-app/issues

REIS0 commented 4 years ago

done

tzarebczan commented 4 years ago

Closing this for now since it's documented on the flathub issue.