search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 413 forks source link

Linting the source code is currently broken #4027

Closed jeffslofish closed 3 years ago

jeffslofish commented 4 years ago

Bug According to https://github.com/lbryio/lbry-desktop/blob/master/CONTRIBUTING.md#lint we should be able to lint the code by running $ yarn lint. However, this currently produces an error because it is trying to lint starting at the top level "src/" directory, but there is no longer a top level "src/" directory. I can fix this issue if you let me know what directories you actually want linted.

To Reproduce Steps to reproduce the behavior:

  1. Run $ yarn lint

Expected behavior The code should be linted.

Screenshots Screen Shot 2020-04-20 at 10 19 58 PM

System Configuration

Additional context Add any other context about the problem here.

tzarebczan commented 4 years ago

Thanks for filing this issue! I would say it's all the directories outside of the . ones.

jeffslofish commented 3 years ago

Linting is still broken for me, but for a different reason. With eslint in package.json set to ^5.15.2, I get the following errors:

image

If I set the eslint version in package.json to the latest release (^7.18.0), then this error goes away. It appears that the older eslint has problems ignoring the directory if it ends in ".js".

Can you reopen this issue, and I'll open a pull request to fix it?

neb-b commented 3 years ago

@jeffslofish Weird error. Just reopened!

jeffslofish commented 3 years ago

Actually, I found a solution to this problem here: https://github.com/eslint/eslint/issues/10880. All you have to do is add single quotes around the glob pattern and then it will work properly. Pull request coming shortly.