search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 413 forks source link

Incorrect render mode on some files #4075

Closed btzr-io closed 3 years ago

btzr-io commented 4 years ago

Bug Some files are reported as Video on the renderMode prop of fileRender component.

File extension: .stl
Content Type:  application/octet-stream

To Reproduce Steps to reproduce the behavior:

  1. Go to any url from the examples list.
  2. See error...

Expected behavior Use the correct viewer for this file, or just don't try to render.

Examples

https://lbry.tv/@GRAVITYSHAPES:f/free-3dprint-bowl-19cm-voronoi-style-no4-stl:8 https://lbry.tv/@GRAVITYSHAPES:f/stl:b

btzr-io commented 4 years ago

@seanyesmunt Any reason to have application/octet-stream listed as FORCE_CONTENT_TYPE_PLAYER ? https://github.com/lbryio/lbry-desktop/blob/eaca77d39430fa6f64af054ac3705c687935c18f/ui/constants/claim.js#L14

DispatchCommit commented 3 years ago

This looks resolved by the 2 linked PR's that are merged.