Inconsistent syles of markdown editor

[btzr-io]

Bug

• [ ] Inconsistent selected text styles
• [ ] Toolbar buttons missing "active" styles
• [ ] The current font is hard to read and there is no need for it ( monospace )
• [ ] Dark theme for markdown editor #4154
• [ ] Reduce the need for toggling preview mode.
• [ ] Add More consistency of styles between edit and preview mode.

To Reproduce Steps to reproduce the behavior:

1. Go to 'Publish area'
2. Use the markdown editor

Expected behavior Consistent styles and colors for all themes.

[Ruk33]

Hello, I would love to help with this issue if that's ok.

I do have a few questions though:

Inconsistent selected text styles

I'm not entirely sure about this one, could you elaborate please?

The current font is hard to read and there is no need for it ( monospace )

Which one should it use? or is it up to the developer to choose one?

Dark theme for markdown editor #4154

I believe this one has already been fixed but would like confirmation.

Reduce the need for toggling preview mode.

You mean by incorporating a WYSIWYG mode?

Add More consistency of styles between edit and preview mode.

If we opt for a WYSIWYG mode I believe this item gets deprecated, please let me know if this is not the case.

Regards.

[btzr-io]

I think some of the style issues where fixed: https://github.com/lbryio/lbry-desktop/pull/464

You mean by incorporating a WYSIWYG mode?

Yes something like that, or at least use a more advance editor ( good compatibility with react and markdown support ). I'm not sure if there is one that we can just import and configure / adapt to the needs of the app.

Alternative solution will be make a custom editor using this or similar frameworks: slate, quilljs etc.

The current editor doesn't support react for the preview mode ( Is converted to DOM string causing some issues ).

Having a better editor is the priority, so most of this issues will be fixed on that process.

Note: I think I tagged the wrong person 😛

[Ruk33]

Note: I think I tagged the wrong person stuck_out_tongue

Haha yeah.

Well I have seen Quilljs and seems to be a good alternative although it outputs HTML. I guess it shouldn't be hard to convert that back to Markdown. Do you want me to give it a try?

[btzr-io]

@Ruk33 I think slate has a more react oriented design but there could be better alternatives. Last time I checked had issues on mobile browsers.

I think prosemirror also looks interesting.

Yes feel free to give it a try, If you need any help let me know.

[btzr-io]

Having a custom editor will allow us to add other features more easily like emojis, better way to include embed lbry content ( videos, audio, etc.. )

[btzr-io]

I think will be better if you check this one: https://github.com/lbryio/lbry-desktop/issues/4639

[Ruk33]

Hello @btzr-io thanks, will take a look at it. Regards.