search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 414 forks source link

Data loss: Don't clear comment field if failed to post #4240

Closed infinite-persistence closed 4 years ago

infinite-persistence commented 4 years ago

Bug I get Unable to create comment, please try again later. quite frequently. The comment that I just entered, which could be paragraphs long or full with markdown formatting, should not be cleared in this event to avoid having to re-type everything again.

To Reproduce I don't know how to reproduce the failure -- it just occurs quite frequently for me. Looking at the log file, I see the same thing for both the success and failure case, so nothing useful to report from here.

Expected behavior The data that I just filled in should remain in the field when failure occurs, so that I can try to post again after a few seconds with the same data.

System Configuration

App: 0.45.2
Daemon (lbrynet): 0.73.1
Platform: Linux (Linux-5.3.0-51-generic-x86_64-with-LinuxMint-19.3-tricia)
infinite-persistence commented 4 years ago

This only impacts the "Simple Editor". The latest master, which includes the Advanced Editor, retains the data well because SimpleMDE by default has the retention feature.

The retention feature in SimpleMDE is another bug, as the data is left there on successful posts (the inverse of the original problem above).

infinite-persistence commented 4 years ago

Closed as duplicate (moving info to 4533)