Closed infinite-persistence closed 3 years ago
Thanks for the issue, appreciate it! A few good points that should be considered soon. Also see https://github.com/lbryio/lbry-desktop/issues/4479
Close
Items are completed. The remaining ones have been split to their own ticket.
[ ] Image uploads (for banner and avatar) should not happen immediately The upload happened immediately after I selected the file. It should happen after
Done
is pressed. What if I chose a wrong and sensitive image?[x] Minor overlap between label and error message 2021-01-27: Issue no longer happening today (someone fixed it)
[x] Cancel button at bottom should return to previous page If I cancel the channel creation using the button at the bottom, it doesn't bring me back to previous page, but always lands in "Your channels" instead. The cancel button at the top does bring me to the previous page. 2021-01-27: I think that's the intended behavior (same thing in Publish) -- "cancel" simply clears off the field, while the top cancel button brings you back to the previous page. Recent UI changes have made this more obvious (although it still confuses me)
[x] Cover image size recommendation string should appear for all cases The Cover Image (6.25:1) advice only appears if you choose a URL. I think it should appear in the File Upload version as well. Same goes for Thumbnails. 2021-02-1: Fixed by 5400
[x] Don't use monospace font for Markdown Editor Unrelated to Channel Creation (but since Simple Editor is no longer used), I think we should not use Monospace fonts for the Markdown Editor since we are not coding. Or at least limit that font usage to just code-blocks (github doesn't, though). 2021-05-21: Fixed by
Markdown editor tweaks 6096
[ ] Need live sanitization for Website and Email input fields?
[ ] Need live sanitization for URL-based banner and icon upload? It seems to be doing live
GET
queries; can perhaps just relay the errors