lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 413 forks source link

bug: the button that expands the followers list found at the top is not labeled according to my screen reader. #5185

Closed marrie closed 3 years ago

marrie commented 3 years ago

Bug

When tabbing or navigating wiht the arrow keys, you will hear "button" at the very top of the screen, if using a screen reader. when pressing this button, the list of who you are following will appear. The button has no label, thereby making it harder for a screen reader user to find the button and go to their follower list.

To Reproduce

I'm using nvda which can be found ere.

  1. launch nvda.
  2. launch the lbry app or the odysee website.
  3. turn off your screen.
  4. use the keyboard to navigate to the "button" It will say "button."
  5. hit enter on the button.
  6. tab or use arrows to find your followers list.

Expected behavior

I should hear what that button does. "see followers" o or what ever that label actually is supposed to be.

Screenshots If applicable, add screenshots to help explain your problem.

System Configuration

screenshot of the about section in the help part of the lbry app.

Additional context n/a

neb-b commented 3 years ago

Thanks for reporting this @marrie

I will make sure this is fixed soon

marrie commented 3 years ago

I'm still able to reproduce this under mac and windows. Thanks so much and happy Sunday.

marrie commented 3 years ago

Thanks for the fix. That was fast.

neb-b commented 3 years ago

@marrie Thanks for closing the issue! I forgot about that. 🙂

If you run into any more screen reader issues please create another issue so we can fix it.