Show commenting unavailable if comment list fails

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.

https://lbry.tech

MIT License

3.56k stars 414 forks source link

Show commenting unavailable if comment list fails #5607

Open tzarebczan opened 3 years ago

tzarebczan commented 3 years ago

Comment server had an outage and users tried to type long comments, which then ended up failing. If they knew it was down, they wouldn't have wasted the effort.

infinite-persistence commented 3 years ago

Is there an announcement (and query) for the downtime duration, or do we simply show "please try again in a few minutes" instead of the text box?
I think the latter won't help much. I hit this too while looking at the comment-edit issue. For my case, the other comments did load, just that i was unable to send a new one until hours later.

tzarebczan commented 3 years ago

I think we'll be moving to web sockets, so that will be be the better way to tell if it's up or not. Right now you'd know if the comment list call errors.

Not sure why you had issues sending - was this recently? Curious what the network calls showed.

infinite-persistence commented 3 years ago

Not sure why you had issues sending - was this recently? Curious what the network calls showed.

Forgot to look -- will do in future. At first I thought it was just due dev mode (not signed in, etc.), but given that 2 others in Discord faced the same thing, perhaps it's something else. But it was just "down" for a couple of hours.

infinite-persistence commented 3 years ago

Happened again just now from 0.49.5. Other comments load fine, but I just can't submit.

{
  "jsonrpc": "2.0",
  "result": {
    "error": {
      "code": -32000,
      "data": null,
      "message": "Error in daemon: Attempting to send rpc request when connection is not available."
    },
    "id": 1,
    "is_claim_signature_valid": false,
    "jsonrpc": "2.0"
  }
}

tzarebczan commented 3 years ago

This issue should be fixed now, it was a quirk with the lbry.tv sdks.