lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 414 forks source link

In-App notifications. #695

Closed hackrush01 closed 4 years ago

hackrush01 commented 7 years ago

Inclusion of an in-app notification system would be helpful in many cases such as if we want the people to move from slack to discord, we could just send an in-app notification for the same. It could be extended to other functionalities such as informing about incoming tips, new content, new upload from subscriptions etc.

tzarebczan commented 6 years ago

Notification scenarios, including the ones mentioned above:

alyssaoc commented 6 years ago

@seanyesmunt This should be considered for an epic

btzr-io commented 6 years ago

WIP (Just the ui, no redux logic yet)

@seanyesmunt any ideas or feedback on this?

notify

kauffj commented 6 years ago

Ooooooh I love this. Not Sean but some quick comments from me:

1) It'd be cool if it showed the number of notifications 2) I'd keep the design consistent. Keep the spacing allocated for the image/icon the same, as well as the header formatting (unless you just couldn't get this to work...) 3) Consider adding elements that allow marking notifications as read or to hide them (see how FB manages theirs) 4) Less stylistic weight could be given to the header

btzr-io commented 6 years ago

notify

Some minor updates, still working on 3

btzr-io commented 6 years ago

colors

neb-b commented 6 years ago

This is awesome @btzr-io.

I agree with @kauffj's comments. Maybe add an x in the corner when you hover over one notification to remove it from the stack. For the redux side this should live inlbry-redux. Probably in the notifications reducer.

I think to keep it simple we can just start with adding newly subscribed content and your publish confirmations: "Your file at lbry://something is published" or something similar.

neb-b commented 6 years ago

Also this should use theFileTile component to keep it consistent with search/related content.

btzr-io commented 6 years ago

publish confirmations: "Your file at lbry://something is published"

@seanyesmunt There is a modal for that, should I remove it?

btzr-io commented 6 years ago

remove-notify

neb-b commented 6 years ago

@btzr-io Sorry I missed your comment.

Maybe we should show the desktop notification if the app is closed, but not if it's open? Will this contain an "in-app" notification when something happens? It would be the same text as the text inside the drop down, but shown right when something happens? Maybe that should be it's own issue.

tzarebczan commented 5 years ago

Another use case now is comment notifications.

kauffj commented 4 years ago

@seanyesmunt https://github.com/lbryio/internal-apis/pull/1326 will make 6 existing notifications consumable via API and make it much easier to add new ones whenever we want

Expect work to begin on this next week if we can find the time (and we probably should)

kauffj commented 4 years ago

@sean ensure it works as intended

kauffj commented 4 years ago