Skip Navigation Accessibility Element Auto Focusing Then Showing on Open

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.

https://lbry.tech

MIT License

3.56k stars 413 forks source link

Skip Navigation Accessibility Element Auto Focusing Then Showing on Open #7049

Open QuirkyRobots opened 3 years ago

QuirkyRobots commented 3 years ago

Michael Mitnick said this is a reported bug and should be fixed by the next update patch. However, I can't find any issues or fixes for it, so I'll post the issue anyway.

When you close the app with the x in the top right, then go to the system tray and open it again, the "Skip Navigation" accessibility element is unhidden and displayed.

I didn't find any issue listed here, but it has been reported in the Foundation.

Might be one for @btzr-io https://github.com/lbryio/lbry-desktop/pull/6470

Possible solutions:

React:

public onOpen = (args: any): void =>{args.preventFocus = true}

On app focus, unfocus elements with CSS.

windowObj.blur();

tzarebczan commented 3 years ago

Thanks for filing, don't think we've seen this one before!

btzr-io commented 3 years ago

What OS ? I can't recreate this issue on windows.

QuirkyRobots commented 3 years ago

What OS ? I can't recreate this issue on windows.

I have Windows 10 and a dual screen setup, one of the screens is a touch screen. That might be the issue. A touch screen. It doesn't seem to affect everyone based on feedback I got.

QuirkyRobots commented 3 years ago

It also doesn't happen all the time. I can't reproduce it today.

btzr-io commented 3 years ago

The button will become visible on focus ( tab navigation ), I think that's the expected behavior. If you want to hide just press tab or click outside the button.

QuirkyRobots commented 3 years ago

That's the issue, it wasn't appearing on focus as such, it was appearing on open. It should be something I never see. I'm not sure what it's purpose is. Should it be there? Anyway, I've not be able to reproduce it recently, so not a big issue if no one else is reporting it. It's just one of those mysteries.