search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 414 forks source link

Comment tip failure causes tip to be resent #7135

Open tzarebczan opened 3 years ago

tzarebczan commented 3 years ago

I know we fixed this issue for livestreams, but it's still a bug outside of them. I was commenting on someone's channel with LBC tip, and it didn't go through (didn't see the error, but saw the message was still up). When I sent again, it sent another set of LBC.

tzarebczan commented 3 years ago

This is actually a different issue from what we fixed -happens when the tip call times out, so the app has no idea if it went through or not, but it actually does - then it prompts to send again.

We probably want to show a message with an error that says comment failed, but tip most likely went through - to check the wallet history.

Or we can try to call txo list and find the txid of a recent tip for the channel that's being tipped.