search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.57k stars 415 forks source link

No tray icon in Arch Linux #740

Closed BrunoDSL closed 5 years ago

BrunoDSL commented 6 years ago

Title explains the issue.

Steps to reproduce

  1. Install lbry-app-bin from AUR
  2. Open LBRY

Expected behaviour

Much like every other Electron app, if the app has a tray icon, it should appear in the tray when the application opens.

Actual behaviour

No tray icon shows up. Closing the app shuts down the daemon and closes the app.

System Configuration

Anything Else

Tested using XFCE

tzarebczan commented 6 years ago

Thanks for the issue @MR4Y ! Sent you a couple LBC on Discord for filing this, it's a good find.

hackrush01 commented 6 years ago

Right now, in Linux, only Debian systems are supported.

Could you please post the output of the following command: pacman -Qi libappindicator1. I could probably use the info to add tray icon support in arch Linux systems.

-Regards -Amit Tulshyan

On Nov 14, 2017 11:23 PM, "Thomas Zarebczan" notifications@github.com wrote:

Thanks for the issue @MR4Y https://github.com/mr4y ! Sent you a couple LBC on Discord for filing this, it's a good find.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lbryio/lbry-app/issues/740#issuecomment-344341912, or mute the thread https://github.com/notifications/unsubscribe-auth/AQxPZhfT6deqfQHvPaz2iZB3H_TOA2gdks5s2dOQgaJpZM4QdXsW .

BrunoDSL commented 6 years ago

Output: error: package 'libappindicator1' was not found

BrunoDSL commented 6 years ago

Updated lbry-app-bin to 0.18.2-1. Still no tray icon.

tzarebczan commented 6 years ago

18.2 was a patch release which fixed a specific new user issue, nothing else was changed.

kauffj commented 6 years ago

@MR4Y I believe Electron only supports tray icons in Linux distributions that support libappindicator1.

BrunoDSL commented 6 years ago

Both Discord AUR buids have tray icons.

ghost commented 6 years ago

Off-topic: I would like to request any information you have regards to building to Arch for a proposal of addition to the instructions if able to resolve this. @MR4Y can we PM on discord?

BrunoDSL commented 6 years ago

Yes.

ghost commented 6 years ago

@etisdew sorry, not sure which MR you are >_<

kauffj commented 6 years ago

@etisdew @MR4Y as far as I know, Electron tray icons will only display if libappindiactor1 is available. See:

Can you guys clarify this issue? Is it:

  1. You have libappindiactor1 installed, but it doesn't work.
  2. You do not have libappindiactor1 installed, and the LBRY install process didn't try to install it.
  3. You do not have libappindaictor1 installed, the LBRY app tried to install it, but it's not available on your system.

If it's 1, we ought to try to debug it a bit further then open with Electron. If it's 2, we can look to modify the set up process. If it's 3, I'm not sure there's much we can do.

hackrush01 commented 6 years ago

OK so I got some time to look at the issue, and this is my diagnosis. 1) libappindicator1 indicator is not installed in the system (pacman -Qi libappindicator1 returned negative). 2) Also the app explicitly checks for libappindicator1 in Debian based systems(https://github.com/lbryio/lbry-app/blob/master/app/main.js#L522) 3) We install dependencies for debian( https://github.com/lbryio/lbry-app/blob/master/package.json#L56), which I think would need to be changed to support arch, fedora etc. systems. 4) We cannot remove the check completely because other quitting functionality depends on this. We would need to include custom checks for different systems.

On Nov 27, 2017 8:01 PM, "Jeremy Kauffman" notifications@github.com wrote:

@etisdew https://github.com/etisdew @MR4Y https://github.com/mr4y as far as I know, Electron tray icons will only display if libappindiactor1 is available. See:

Can you guys clarify this issue? Is it:

  1. You have libappindiactor1 installed, but it doesn't work.
  2. You do not have libappindiactor1 installed, and the LBRY install process didn't try to install it.
  3. You do not have libappindaictor1 installed, the LBRY app tried to install it, but it's not available on your system.

If it's 1, we ought to try to debug it a bit further than open with Electron. If it's 2, we can look to modify the set up process. If it's 3, I'm not sure there's much we can do.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lbryio/lbry-app/issues/740#issuecomment-347198180, or mute the thread https://github.com/notifications/unsubscribe-auth/AQxPZsrl5-RiVKhiqMEJmfuBb654UQ84ks5s6sengaJpZM4QdXsW .

BrunoDSL commented 6 years ago

@kauffj As I explained earlier all AUR builds of Discord have tray icons. None of them require libappindicator1. Discord uses libnotify instead.

johndoe01012 commented 5 years ago

Trying to reproduce the issues, and it's not applied to the latest version. The tray icon is showing up as expected. I guess just close the issue, or did I miss something here?

tzarebczan commented 5 years ago

Woohoo, we may have fixed it up some other icon changes we made. Closing... Thanks @vv181