search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 413 forks source link

LBRY Crashes on watching any video after upgrade to 0.52.2 #7467

Closed goatsrcool closed 2 years ago

goatsrcool commented 2 years ago

Bug Upgraded from 0.39.1 to 0.52.2. Trying to watch any video causes LBRY 0.52.2 to crash after a second or two, though I can still hear the video playing in the background.

I ran LBRY in command-line mode and got the following:

C:\Program Files\LBRY>lbry /?

C:\Program Files\LBRY>
SDK already running
Sandbox listening on port 5278.
[10:36:55.446] [info] Checking for update
[10:36:56.164] [info] Update for version 0.52.2 is not available (latest version
: 0.52.2, downgrade is disallowed).
[10760:0212/103711.355:ERROR:gl_surface_presentation_helper.cc(260)] GetVSyncPar
ametersIfAvailable() failed for 1 times!

lbry_crash

System Configuration

jessopb commented 2 years ago

Thanks for the report - can you make sure the daemon version under help is 0.106?

goatsrcool commented 2 years ago

Thanks for the report - can you make sure the daemon version under help is 0.106?

Yes, seems to be:

Daemon (lbrynet) | 0.106.0

jessopb commented 2 years ago

I'll see if I can make a build for you to test this week.

jessopb commented 2 years ago

https://github.com/electron/electron/issues/32317 looking at this now.

infinitebus commented 2 years ago

I have the same problem, audio runs behind a Windows appcrash message. Running 0.52.2 in Win7 64-bit. Lbry has been working fine since long, this happened after accepting a recent in-app offer for an update. Went back to 51.1. It now gave message about "incompatible daemon" and continue anyways, which I did. Worked fine, no appcrash when playing a video. I then accepeted the in-app offer for 52.5, now it crashes again when pressing play.

nemo859 commented 2 years ago

I've noticed that adding --disable-cpu to the command line when launching LBRY.exe will produce a black screen while the app crashes, and --disable-gpu will produce video and audio playing in the background but the app still crashes.

rasskden commented 2 years ago

Hello! I also faced this problem. Version v0.52.5, Windows 7 x64. But I've noticed that the app doesn't crash, if the video is initially without sound - I uploaded a video made with sound off and it played fine and the app didn't crash. Maybe this will help...

jessopb commented 2 years ago

https://www.electronjs.org/releases/stable?version=15#15.3.5 Thanks for finding this - there seems to be a patch in electron 15.3.5 that fixes media crashes in older windows version. we're on 15.3.2. will try asap!

nemo859 commented 2 years ago

patch in electron 15.3.5 that fixes... we're on 15.3.2. will try asap!

Great, thanks hope it fixes the issue, personally I wish there was an option to render the video using libVLC with electronjs, which is possible, though it is more readily convenient for developers to use a BrowserWindow to render video from webkit, I guess that's what is being done here as I saw this same error being discussed for other chromium\webkit based projects.

Check out the wcjs-player & wcjs-prebuilt modules if you want to go this way, they are node wrappers for the webchimera.js video player, which uses VLC in the background. (I'm not affiliated with them, just currently using the modules for something similar in one of my projects with success so far.)

nemo859 commented 2 years ago

Also I wanted to say VLC has support for MKV and AVI formats which webkit doesn't support, so that'd be nice too because I have to open some videos on LBRY in VLC now even before it started crashing every time.

nemo859 commented 2 years ago

I can confirm 0.52.6-alpha-2 currently fixes this crash.

I was able to watch videos with no crashes using it, thanks.

goatsrcool commented 2 years ago

Yes 0.52.6-alpha-2 confirmed working here too, thank you B)