search

lbryio / lbry-desktop

A browser and wallet for LBRY, the decentralized, user-controlled content marketplace.
https://lbry.tech
MIT License
3.56k stars 414 forks source link

LBRY crashes to desktop when trying to upload on Windows 7 starting at v0.5.36 #7732

Closed Sessh22 closed 2 years ago

Sessh22 commented 2 years ago

Basically, when trying to upload a file at the upload screen, either using the Browse button to select a file via explorer or using drag-n-drop on the file results in the app crashing to desktop. This doesn't happen on 0.5.35, but does on 0.5.36 and 0.5.37.

To repro:

Of course, expected behavior is the file is accepted and the app functions normally.

I do see that in 0.5.36, there's an entry for "fixed various upload bugs including transcoding" which might be significant.

IceGuye commented 2 years ago

I have the same issue in Linux (Fedora 37) . This bug happens when the file is large. Even with smaller file, such as a few mb short video, you can clearly feel that the lbry-desktop app is freezing for a few seconds.

jessopb commented 2 years ago

Can you specify: 1) whether you're checking transcoding 2) size/format of file 3) whether you have "preview" enabled so you see the confirm/upload modal?

Sessh22 commented 2 years ago
  1. Not using transcoding
  2. 720p MP4 (h.264) / files are large between 500MB - 1GB and are 4+ hours long. Weekly uploader.
  3. I do see the preview/confirm upload screen
Sessh22 commented 2 years ago

Alrighty. Nice to see it was easy to repro for you at least. Hopefully not too much trouble to sort out.

Sent with Proton Mail secure email.

------- Original Message ------- On Monday, November 14th, 2022 at 10:44 AM, jessopb - notifications at github.com @.***> wrote:

Looks like disk usage spikes to 100% on file select. Looking into it.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

IceGuye commented 2 years ago
  1. Not checking the transcoding.
  2. 1 to 1.5 GB, 1 to 1.5 hours long, formats are MP4 H.264, WEBM VP9 (both crashed).
  3. I have "preview enabled", but different from Sessh22, I can't even see the preview window. Right after selecting the file, the app would freeze and then crash in seconds. I can't even click the submit button.
Sessh22 commented 2 years ago

Perhaps I misunderstood. I have the preview enabled, but I get nowhere near being able to see it because as already stated, the app crashes a few seconds after selecting the file to upload. I thought he was asking if I had it enabled at all. I figured it was already assumed I wasn't actually seeing it because the app crashed almost immediately after selecting the file. Sorry for the confusion.

My situation is identical to yours, IceGuye. Jessopb replied saying disk usage spikes to 100% and that he's looking into it which is what my email reply was in response to, but his post stating that didn't show up here for some reason. :)

jessopb commented 2 years ago

I've reproduced the problem. It is described in the limitations section of this link: https://www.npmjs.com/package/get-file-object-from-local-path I'll have a fix out today or tomorrow. The disk usage spikes were not the problem - that was my old windows vm.

Sessh22 commented 2 years ago

Great I'll be sure to test that out when it's available.

jessopb commented 2 years ago

PR is ready, but we have a release issue I'm waiting for.

jessopb commented 2 years ago

The alpha release with the fix is in releases now!

Sessh22 commented 2 years ago

I grabbed it and it now lets me select a file and everything appears to be normal. I can get to the preview screen now and did everything except push it through. Looks good!

IceGuye can hopefully test on his Linux box as well just to be sure.

IceGuye commented 2 years ago

Tested on the last git pull. I can upload in Linux now.

jessopb commented 2 years ago

yay!