Closed tzarebczan closed 4 years ago
Can I grab this one?
That'd be awesome @brentmclark !
Thanks @kauffj! I could use a little help with the verbiage, though. I'm not particularly familiar with this product.
So far, I have this when checked:
and this when unchecked:
@brentmclark Those are looking great!
Thanks, @seanyesmunt! I still have some work to do to get the strings into app-strings.json
and the styles into the SCSS files. The app-strings
implementation looks pretty straightforward, but I could use some help finding the optimal place for my styles.
For example, the red copy above. Can I add a --color-warning
variable to the _vars.scss
file or should this be treated as a one-off?
Similarly, for the form field descriptions that rest atop their respective form fields; I see you're using BEM
. Does it make sense to extend the fieldset-section
block with something like fieldset-section__description
and fieldset-section__description--subtext
?
@brentmclark The app-strings
will be populated automatically so you don't need to worry about those.
You can just use .error-text
for the red text.
For the additional text we should probably just use the helper
prop, since we use that in other places. Maybe both the error and description text should be passed as helper
? Not sure how that would look.
@seanyesmunt Thanks for the quick feedback; I'll give these a shot tonight.
@seanyesmunt .error-text
worked great; thanks!
The helper
prop renders content below the checkbox instead of above the checkbox. To me, it doesn't read properly when rendered below the checkbox in this instance. Thoughts?
Oh my goodness I'm dense 😛. How do you feel about this approach instead?
That's looking great!
Awesome. I'll cut the PR tonight. Thanks for your help!
A copy few suggestions:
The vertical spacing is also a bit inconcistent, but that doesn't necessarily need to be fixed and can probably be left to @seanyesmunt
may be it's time to close this issue?) it's in the master already)
Anything Else
Screenshots