Closed btzr-io closed 3 years ago
I signed off on this (possibly I shouldn't have ;), but IIRC @IGassmann had a reason for making this change.
@kauffj It was a temporary solution that we discussed on a call. I'll work on it to result in a more reliable code.
Should be easy to fix adding a search for files *.css in the static/themes folder, let me now @IGassmann if you want me to take this one :).
Themes are currently hardcoded here: https://github.com/lbryio/lbry-app/blob/c894567eb9ded7f8f6802ec30de415e78c10ac84/src/renderer/redux/actions/settings.js#L49
EDIT: I didn't see the link to the previous code, so this was completely implemented before...
@Arrowana there were some problems with the previous solutions. That's why I temporarily hardcoded the themes.
The Issue
Steps to reproduce
/themes
folder.Expected behaviour
The theme selector should recognize new themes added to the
/themes
folder.Actual behaviour
The theme selector doesn't recognize new themes.
Anything Else
Introduced here -> https://github.com/lbryio/lbry-app/pull/865/commits/0852ed033b0532e77c86ef3fe09c8ff0244dba29