lbryio / lbry-redux

Common shared app components for desktop and mobile
MIT License
15 stars 41 forks source link

Add precommit script to build module with each commit #18

Open tzarebczan opened 6 years ago

tzarebczan commented 6 years ago

@seanyesmunt and @akinwale discussed this as a method to ensure code is not injected when modules are built locally and committed to github.

neb-b commented 6 years ago

Just spent a little time on this but I'm seeing this when adding yarn build to the precommit hook

ERROR in Flow: Out of Retries

The flow server is not responding (3 retries remaining): -The flow server is not responding (2 retries remaining): \The flow server is not responding (1 retry remaining): |The flow server is not responding (0 retries remaining): /
Out of retries, exiting!

Not really sure what's happening

kauffj commented 6 years ago

It's pretty clear what's happening @seanyesmunt. You're out of retries.

neb-b commented 6 years ago

It shouldn't be running a flow server though. I don't think so. Flow server is used when you want flow to watch your files.

On Thu, May 10, 2018, 10:15 AM Jeremy Kauffman notifications@github.com wrote:

It's pretty clear what's happening @seanyesmunt https://github.com/seanyesmunt. You're out of retries.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lbryio/lbry-redux/issues/18#issuecomment-388066542, or mute the thread https://github.com/notifications/unsubscribe-auth/AQGcjo5pvjG6xplUhcAybSCFIheyxfSYks5txEucgaJpZM4T1wR1 .

kauffj commented 6 years ago

I was joking.

neb-b commented 6 years ago

Once again my ability to notice jokes has failed me.