search

lbryio / lbry-redux

Common shared app components for desktop and mobile
MIT License
15 stars 43 forks source link

Add error when display type not passed to doNotify #30

Open tzarebczan opened 6 years ago

tzarebczan commented 6 years ago

The Issue

Per comments in https://github.com/lbryio/lbry-app/pull/1493#issuecomment-390298790, we should add an error when the doNotify function does not contain all required parameters. If we don't, the notifications get queued up and other notifications don't show afterwards.

System Configuration

Anything Else

Screenshots

jessopb commented 5 years ago

Agreed, I think my socialShare modal commit was good, but I cancelled it because my feature branch was behaving very strangely. The wallet

doNotify button (notification object which has no id) was matching to my MODALS.SOCIAL_SHARE constant which was also undefined causing it to run my component without the rest of its props, crashing the app.

Also, modalRouter checks to see if "notification" exists, but doesn't check to see if notification.id exists before the switch statement switches on 'id'.