claim_search: Don't clear previous page results if subsequent pages timeout.

lbryio / lbry-redux

Common shared app components for desktop and mobile

MIT License

15 stars 41 forks source link

claim_search: Don't clear previous page results if subsequent pages timeout. #365

Closed infinite-persistence closed 4 years ago

infinite-persistence commented 4 years ago

Issue

https://github.com/lbryio/lbry-desktop/issues/4609

Change

Don't clear existing results on timeout.
Mark the "no more results" flag so that the app knows it needs to stop querying.

infinite-persistence commented 4 years ago

Changes

Created separate flag to differentiate between "no more results" and "partial-page timeout", as sometimes we'll need to purge the data as query doesn't hold the Freshness info.
Avoid doing early returns as suggested.

Note Assuming this is shared with Android, this may or may not break Android. In Desktop, we had to listen to the new flag to stop querying the next page.

infinite-persistence commented 4 years ago

Change

Reverted back to the simple version of just using an existing flag + not purging if results already exists. The only downside to this is that the "timeout" message will no longer appear, and it might look unresponsive when switching between various filters that all result in timeout.

neb-b commented 4 years ago

@infinite-persistence Does the timeout message appear for searches that timeout on the first page?

infinite-persistence commented 4 years ago

@infinite-persistence Does the timeout message appear for searches that timeout on the first page?

Yup, for that case (count = 0), the message will appear as per existing version.