search

lbryio / lbry-redux

Common shared app components for desktop and mobile
MIT License
15 stars 43 forks source link

Transaction export: move file-creation to background. #404

Closed infinite-persistence closed 3 years ago

infinite-persistence commented 3 years ago

Move the file-creation code to the background so that it won't stall the GUI if the list is large.

In actuality, a 100k CSV only took 1 second on my slow VM to generate, so we could avoid this PR if we want. But I think we should still not do it in the GUI thread in case the columns get larger, or we expand doFetchTransactions's default to beyond 100k entries.

kauffj commented 3 years ago

@tzarebczan has concerns about performance of the export function. We may need to consider how to properly design and scale this feature. Will start a conversation with @andybeletsky.