search

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.19k stars 483 forks source link

sanitize sensitive variables #3374

Open gizzatov opened 3 years ago

gizzatov commented 3 years ago

You have that variable that contain private data. Also sometime you use the log.exception method. In this case you can cause situation where private data could be compromated in your logs. https://github.com/lbryio/lbry-sdk/blob/bce299ccc725bebb353d57efe50228e0f8cc8f1e/lbry/wallet/transaction.py#L880

will be better to sanitize logs and tracebacks by some dictonary with sensitive variables.

tzarebczan commented 3 years ago

Thank you for filing. I don't think there's any cases of this being logged.

If you want to take a shot at making this more full proof, we'd appreciate it!