Fix wallet encryption design

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.

https://lbry.com

MIT License

7.19k stars 482 forks source link

Fix wallet encryption design #3455

Open lyoshenka opened 2 years ago

lyoshenka commented 2 years ago

Current wallet encryption is simple AES, so its impossible to differentiate between a wrong password and a corrupted wallet file. We need to add an HMAC to make password checking easy.

moodyjon commented 2 years ago

See this https://github.com/lbryio/lbry-sdk/issues/3658 for trouble this caused in tests.