search

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.19k stars 482 forks source link

Enable macOS universal binary builds #3516

Closed robd003 closed 2 years ago

robd003 commented 2 years ago

Python 3.9 supports universal2 builds so had to update to that

ref: https://github.com/lbryio/lbry-sdk/issues/3515

robd003 commented 2 years ago

@jackrobison could you take a look at this when you get a moment?

jackrobison commented 2 years ago

@robd003 does using universal builds require 3.9? If so then this is a little more involved - I know aiohttp had some breaking changes. I think it would be nice to update to 3.9 but if possible this can be a separate pr/issue.

robd003 commented 2 years ago

@robd003 does using universal builds require 3.9? If so then this is a little more involved - I know aiohttp had some breaking changes. I think it would be nice to update to 3.9 but if possible this can be a separate pr/issue.

Python 3.9 is required: https://docs.python.org/3/whatsnew/3.9.html#macos-11-0-big-sur-and-apple-silicon-mac-support

I can open another pull request to upgrade aiohttp to 3.6.1 and go through the rest of the modules that might need updating.

eukreign commented 2 years ago

@robd003 i started porting SDK to Python 3.9 back in August, you are welcome to pickup where i left off. essentially the issue is that the tests monkey patch certain Python packages and in 3.9 this monkey patching is no longer allowed so the tests fail.

See PR: https://github.com/lbryio/lbry-sdk/pull/3404

to get SDK to work on 3.9 would require refactoring these tests. i believe all of the affected tests are in the DHT module, perhaps @jackrobison or @shyba can provide further guidance.

robd003 commented 2 years ago

@robd003 i started porting SDK to Python 3.9 back in August, you are welcome to pickup where i left off. essentially the issue is that the tests monkey patch certain Python packages and in 3.9 this monkey patching is no longer allowed so the tests fail.

See PR: #3404

to get SDK to work on 3.9 would require refactoring these tests. i believe all of the affected tests are in the DHT module, perhaps @jackrobison or @shyba can provide further guidance.

Awesome! I'll take a look at the PR and see if I can help :)

eukreign commented 2 years ago

this has been moved up in priority and i'm going to pickup the PR i started back in August. we should sync up. are you on lbry discord?

robd003 commented 2 years ago

this has been moved up in priority and i'm going to pickup the PR i started back in August. we should sync up. are you on lbry discord?

@eukreign Could you send an invite link to the discord?

eukreign commented 2 years ago

@robd003 https://discord.gg/68ee4usp

kauffj commented 2 years ago

Closed pending Python 3.9 upgrade