search

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.19k stars 482 forks source link

Add wallet json-schema, validate in one test. #3572

Closed orblivion closed 2 years ago

orblivion commented 2 years ago

A replacement for the would-be protobuf pull request. Depends on this PR: https://github.com/lbryio/types/pull/48/files

The idea is to add the wallet file format to the list of our known formats. This PR will confirm that Wallet.to_dict generates a wallet that conforms to the spec. This way we'll at least have some assurance that the spec is up to date.

I sort of made a guess as to what directory wallet.json would be best to go into.

BTW I added this to Makefile to try to match the protoc stuff, but running make doesn't seem to generate all of the python files that are there. There ends up being files removed from the repository.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.1%) to 71.734% when pulling b483dc2c573702e14363bafbfed0be5da8fa9f81 on orblivion:json-schema into 8cdcd770c0530fb854a470ac610f8865c8e12a1b on lbryio:master.