search

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.19k stars 482 forks source link

grpcio==1.38.0 dependency can't build from source on MacOS aarch64 (M1) #3643

Closed moodyjon closed 2 years ago

moodyjon commented 2 years ago

The complaints from clang include -Wunreachable-code, -Wunused-but-set-variable plus a missing declaration for lseek().

(lbry-venv-3.9) swdev1@Jonathans-Mac-mini lbry-sdk % /Library/Developer/CommandLineTools/usr/bin/clang++ --version   
Apple clang version 13.1.6 (clang-1316.0.21.2.5)
Target: arm64-apple-darwin21.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
(lbry-venv-3.9) swdev1@Jonathans-Mac-mini lbry-sdk % /Library/Developer/CommandLineTools/usr/bin/clang --version 
Apple clang version 13.1.6 (clang-1316.0.21.2.5)
Target: arm64-apple-darwin21.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

I have explored various versions in the range 1.38.0 .. 1.46.0. The lowest version that would build on my machine was grpcio==1.39.0.

I propose bumping to grpcio==1.46.0, first in lbryio/herald, lbryio/hub repositories, then lbry-sdk.

Here are the downloadable pre-compiled options: https://pypi.org/project/grpcio/1.46.0/#files

I will still have to build from source on MacOS aarch64, but it builds without hacking setup.py to change the version in my workspace.

moodyjon commented 2 years ago

Closed by https://github.com/lbryio/lbry-sdk/pull/3647