Updating channel's public key doesn't remove channel part from canonical_url, and doesn't invalidate old signatures for claim_search - Githubissues

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.

https://lbry.com

MIT License

7.19k stars 482 forks source link

Updating channel's public key doesn't remove channel part from canonical_url, and doesn't invalidate old signatures for claim_search #3645

Open keikari opened 2 years ago

keikari commented 2 years ago

[ ] This claim has invalid signature and its canonical_url can't be resolved. lbrynet claim search --claim_id 627b91a663e00607d58b723370d2f81b69edf57c

Resolving canonical_url from above gives lbry://@KeyTestChannel:d/testimage:6 has invalid channel signature

[ ] Making new signing key for channel, doesn't invalidate old signatures properly for claim_search
1. Have a channel with claims on it
2. Update channel's signing key
3. The claims signed with old key are still returned with lbrynet claim search --channel channel --valid_channel_signature even though the signatures are now invalid.

This returns 3 claims, but only 1 has valid channel signature. lbrynet claim search --channel @keytestchannel --valid_channel_signature