lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.2k stars 483 forks source link

Better Support blocklist reposting #3670

Open jessopb opened 1 year ago

jessopb commented 1 year ago

We propose the general principle that claim_list should always be able to show you your claims and their references in entirety (with exception of sd hash) resolve if blocked returns the error, respecting the block list. claim_search filters out blocked claims.

Currently, it seems claim_list with --resolve does not resolve reposted claims. Currently, we cannot look up a particular blocked item or channel with a blocked item in the event of a dispute/unblock.

kauffj commented 1 year ago

@eukreign this ought to be a priority after current work is complete. Please discuss with @jessopb and/or bring up on next stand up if there are questions here.

jessopb commented 1 year ago

Does it make sense to resolve and then if necessary, do the blockchain lookup and filter out the sdhash if resolved returned blocking error?

eukreign commented 1 year ago

@kauffj I would need more info on how this would work. Currently claim_list --resolve simply calls resolve in the background to provide the claim list with extra resolved metadata. If a claim is blocked from being resolved then claim_list --resolve couldn't resolve it just as plain resolve can't resolve it.

jessopb commented 1 year ago

Use lbry.wallet.Network.get_claim.by_id for the repost, Then/and resolve the url to know if you should filter.

jessopb commented 1 year ago

https://github.com/lbryio/lbry-sdk/issues/3676 made an issue for fourth bullet point.