search

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.2k stars 483 forks source link

internal fixes for intermittent test failures #3707

Closed moodyjon closed 1 year ago

moodyjon commented 1 year ago

This completes pretty much all the work I planned to do on lbry-sdk test reliability. It should unblock more python3.9 work.

Fixes #3665 Fixes #3671

Bumping hub gets us the benefit of these fixes: https://github.com/lbryio/hub/issues/98 https://github.com/lbryio/hub/issues/101 https://github.com/lbryio/hub/issues/104

I also revisited #3658 because I encountered a new zlib.error "invalid window size".

I've started seeing failures like this when running tests. Something changed in the environment I think. https://github.com/moodyjon/lbry-sdk/actions/runs/3447835647/jobs/5754426649 Successful run from 2mo ago with python 3.7.14 (failure was with 3.7.15): https://github.com/moodyjon/lbry-sdk/actions/runs/3108575245/jobs/5038289310 Upgrade to pyinstaller==4.6 was suggested here: https://github.com/pyinstaller/pyinstaller/issues/6325

coveralls commented 1 year ago

Coverage Status

Coverage remained the same at 56.648% when pulling 6ec9ede0aa533cf33cbb9f6f00b485a04e8c025f on moodyjon:misc_test_fixes2 into 8c6c7b655c9ddd815e7dbaa2a53707cf2948e1cf on lbryio:master.