search

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.2k stars 483 forks source link

Handle workflow deprecations #3722

Closed moodyjon closed 1 year ago

moodyjon commented 1 year ago

Fixes #3721

I discovered that the: echo "var=value" >> $GITHUB_OUTPUT needs to be (on windows only): echo "var=value" >> $env:GITHUB_OUTPUT

That's the main reason I switched to using $GITHUB_ENV instead of $GITHUB_OUTPUT. At least reading from the variable looks the same on windows & linux/Mac.

eukreign commented 1 year ago

need rebase

coveralls commented 1 year ago

Coverage Status

Coverage: 56.58% (+0.004%) from 56.577% when pulling 6e518a74ea67aa36726c11c0d989279184719cdd on moodyjon:handle_workflow_deprecations into a2da86d4b576bf316560a123cb568d8e1826d5b3 on lbryio:master.

eukreign commented 1 year ago

there is no way to avoid this duplication? how do other multi-platform projects do it?

moodyjon commented 1 year ago

there is no way to avoid this duplication? how do other multi-platform projects do it?

Used the 'shell: bash' option to simplify this. Windows will now use bash syntax to refer the the environment variable which I didn't think was possible.