lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.2k stars 483 forks source link

Some files get incorrect duration #3729

Open keikari opened 1 year ago

keikari commented 1 year ago

This file is ~48h long, but metadata has stored duration as ~22min. https://odysee.com/@HumanitysVault:a/Michael-Tsarion-massive-audio-collection-of-interviews-no.1-(48h):1

File itself has correct number in metadata based on ffprobe.

ffprobe -v quiet -print_format json -show_format -show_streams  "https://player.odycdn.com/api/v4/streams/free/Michael-Tsarion-massive-audio-collection-of-interviews-no.1-(48h)/113d2161325a8df40a5f2387c31a0290a34d4109/a5da50"

{
    "streams": [
        {
            "index": 0,
            "codec_name": "mp3",
            "codec_long_name": "MP3 (MPEG audio layer 3)",
            "codec_type": "audio",
            "codec_tag_string": "[0][0][0][0]",
            "codec_tag": "0x0000",
            "sample_fmt": "fltp",
            "sample_rate": "44100",
            "channels": 2,
            "channel_layout": "stereo",
            "bits_per_sample": 0,
            "r_frame_rate": "0/0",
            "avg_frame_rate": "0/0",
            "time_base": "1/14112000",
            "start_pts": 353600,
            "start_time": "0.025057",
            "duration_ts": 2457692282880,
            "duration": "174156.199184",
            "bit_rate": "192000",
            "disposition": {
                "default": 0,
                "dub": 0,
                "original": 0,
                "comment": 0,
                "lyrics": 0,
                "karaoke": 0,
                "forced": 0,
                "hearing_impaired": 0,
                "visual_impaired": 0,
                "clean_effects": 0,
                "attached_pic": 0,
                "timed_thumbnails": 0,
                "captions": 0,
                "descriptions": 0,
                "metadata": 0,
                "dependent": 0,
                "still_image": 0
            },
            "tags": {
                "encoder": "Lavf"
            }
        }
    ],
    "format": {
        "filename": "https://player.odycdn.com/api/v4/streams/free/Michael-Tsarion-massive-audio-collection-of-interviews-no.1-(48h)/113d2161325a8df40a5f2387c31a0290a34d4109/a5da50",
        "nb_streams": 1,
        "nb_programs": 0,
        "format_name": "mp3",
        "format_long_name": "MP2/3 (MPEG audio layer 2/3)",
        "start_time": "0.025057",
        "duration": "174156.199184",
        "size": "4179749451",
        "bit_rate": "192000",
        "probe_score": 51,
        "tags": {
            "encoder": "Lavf58.20.100"
        }
    }
}

Downloaded the file and tried this on recent master:

lbrynet stream create --name "1" --bid 0.001  --file_path '/home/user/Downloads/Michael Tsarion massive audio collection of interviews no.1 48h.mp3' --preview

And output had this:

"value": {
        "audio": {
          "duration": 1356  ### Would've expected 174156
        },
Sohailsaifi commented 8 months ago

I want to work on this issue. Please assign it to me.

moodyjon commented 8 months ago

Done. I can review your pull request, but I'm not sure of the capacity to issue new releases.