search

lbryio / lbry-sdk

The LBRY SDK for building decentralized, censorship resistant, monetized, digital content apps.
https://lbry.com
MIT License
7.2k stars 483 forks source link

Fix checking protocol version #3739

Open ben221199 opened 1 month ago

ben221199 commented 1 month ago

This pull request fixes issue #3738.

ben221199 commented 1 month ago

In addition, the code was added by @jackrobison in https://github.com/lbryio/lbry-sdk/commit/1bf51e855d35013feb8a079153a913e1965f52a9.

ben221199 commented 1 month ago

The commit was made after tagging v0.53.2, so the bug got released in v0.53.3.

If someone wants to write a LBRY hub themselves, note that v0.53.2 doesn't have the bug, v0.53.3 to v0.113.0 have the bug, and if this pull request gets tagged as v0.114.0, from that version onwards the bug should be fixed.

ben221199 commented 1 month ago

Hi @shyba, can you rerun the workflows again from here? It seemed they stopped and even disappeared.

coveralls commented 1 month ago

Coverage Status

coverage: 56.987% (-0.1%) from 57.083% when pulling 191627e4f764992275a3a92191c857d97158e027 on ben221199:master into eb5da9511e162ef1080cb34af2ee087383cfa94a on lbryio:master.