search

lbryio / lbry.go

MIT License
29 stars 20 forks source link

Rename this repo #17

Closed kauffj closed 6 years ago

kauffj commented 6 years ago

lbry.go is a confusing name for what this does.

Also, should this be public?

tiger5226 commented 6 years ago

please let me know if we do this as Chainquery depends on its packages.

kauffj commented 6 years ago

@tiger5226 what's in here that Chainquery relies on? Should it be split out?

It's possible I'm not understanding everything this repo does. In my head, this is the "YouTube sync repo"

tiger5226 commented 6 years ago

We use a lot of stuff. So does internal-apis. It is the repo grin has designated as the Go repo for all things LBRY. So if anything is shared between go apps it goes here. Specifically from the gopkg.lock file 

packages = [
    "api",
    "errors",
    "jsonrpc",
    "lbrycrd",
    "null",
    "querytools",
    "stop",
    "travis",
    "util",
    "validator"
  ]
kauffj commented 6 years ago

So obviously this repo should be named lbry-libraries.go.

tiger5226 commented 6 years ago

how about bookshelf.go? Stays with the LBRY theme and signifies lots of choices. No strong preference, just thought it was a playful name. @lyoshenka remarked "The swiss army knife" previously, although I think he removed that for the same reasons you want to rename the repo.

I strongly believe any lbry.go repo should be reserved for the daemon rewrite as that is what any one would think this repo was.

Additionally, lbryschema.go, and reflector.go use this as well I believe.

alyssaoc commented 6 years ago

@kauffj and @lyoshenka is this something you want to tackle? It won't be easy, but sooner rather than later. Perhaps a better readme?

kauffj commented 6 years ago

This is for @lyoshenka only. I noticed he already started splitting some parts of this repo out.

lyoshenka commented 6 years ago

ill rename this eventually

alyssaoc commented 6 years ago

closing for now