search

lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol
https://lbry.com
MIT License
2.57k stars 178 forks source link

Consider tuning ancestor/descendant size limit for our use case #139

Closed shyba closed 5 years ago

shyba commented 6 years ago

While publishing lots of videos, @nikooo777 got: Transaction rejected: 64: too-long-mempool-chain

Which comes from: https://github.com/lbryio/lbrycrd/blob/4ff143387ef98ffb7e57b3b07f11714589f6d85c/src/main.cpp#L1249

Which is affected by: -limitancestorcount -limitancestorsize -limitdescendantcount -limitdescendantsize

At the time it last happened, this was the mempool info output:

[lbry@lbryum8:~] $ ./lbrycrd/lbrycrd-cli getmempoolinfo
{
 "size": 82,
 "bytes": 84031,
 "usage": 159920,
 "maxmempool": 300000000,
 "mempoolminfee": 0.00000000
}

This issue opens a discussion on what would be the best move on this subject and if there are other solutions.

shyba commented 6 years ago

Solution I would consider: What if the node being used for large scale publishes raises this limit? Will the mempool get rejected by other nodes all the time? Would it solve or trigger another issue?

alyssaoc commented 6 years ago

@shyba and @nikooo777 Is this still an issue? What is the impact/priority?

alyssaoc commented 5 years ago

closing per conversation with Niko and Victor