search

lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol
https://lbry.com
MIT License
2.57k stars 178 forks source link

CClaimTrieCache should be renamed #145

Closed kaykurokawa closed 5 years ago

kaykurokawa commented 6 years ago

The naming of CClaimTrieCache in claimtrie.h/.cpp has caused a lot of confusion. It is not a Cache for CClaimTrie, it is a cache of pending changes to CClaimTrie upon block increment/decrement.

kaykurokawa commented 6 years ago

CClaimTrieUpdateBuffer might be a good name

bvbfan commented 6 years ago

I wrote in pull request, but should be here. I can take it on my branch too + split in own file.

bvbfan commented 6 years ago

https://github.com/lbryio/lbrycrd/pull/160

bvbfan commented 6 years ago

You can merge safety, it has only rename and separate.

BrannonKing commented 5 years ago

Now that the new one acts like a cache, we decided that renaming it was not necessary.