search

lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol
https://lbry.com
MIT License
2.57k stars 178 forks source link

Sanitize claimtrie RPC commands. #167

Closed winder closed 6 years ago

winder commented 6 years ago

Change for issue #125

I wasn't exactly sure how you deal with upstream test changes, but I'm pretty sure this isn't it. For now, I went ahead and updated the existing rpc_tests suite instead of copying over the CallRPC utility. Is there a better spot, or approach?

tzarebczan commented 6 years ago

@winder , thanks for this contribution! Please review our contributing guide if you have not done so already. Also, click here if you are interested in an LBC tip for your work :)

We'll also be adding you to our developer mailing list so we can keep in touch (you can unsubscribe anytime!).

We'll get a proper review on this PR from one of the devs.

winder commented 6 years ago

@kaykurokawa I think everything should be good now.

lbrynaut commented 6 years ago

The style needs to be addressed (clang-format).

winder commented 6 years ago

I wasn’t sure what to do about the failing builds. There error messages are sort of hidden inside the reproducible build script.

On Tue, Jul 10, 2018 at 11:07 PM lbrynaut notifications@github.com wrote:

@lbrynaut requested changes on this pull request.

Looks good to me other than the failing travis builds.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lbryio/lbrycrd/pull/167#pullrequestreview-136077600, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHqRTFmInJYsYC6D-ZeUjWMnIvU_p12ks5uFWvigaJpZM4U-HPC .

kaykurokawa commented 6 years ago

I will rebase/squash/fix the travis errors and merge. Thanks for the contribution!

kaykurokawa commented 6 years ago

rebased/formatted/squashed and merged