search

lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol
https://lbry.com
MIT License
2.57k stars 178 forks source link

Support for CLion Intellisense #177

Closed BrannonKing closed 6 years ago

BrannonKing commented 6 years ago

(not to be used for a full compile of the project)

lbrynaut commented 6 years ago

@BrannonKing I'm not sure why this is needed, but since it doesn't impact any existing code (and so long as it continues not to) and you're willing to maintain it, I don't see the harm. Perhaps it makes more sense to be moved into contrib/devtools though? If it must exist in the root directory, could it be sym-linked in autogen.sh or something?

BrannonKing commented 6 years ago

@lbrynaut , it's needed for the CLion code navigation features to work. It does need to be in the root to work. I'm okay putting it into devtools plus a symlink as you suggest, although I would like to make it actually compile the full project once you're done merging in the current bitcoin codebase. At that point I think it's a legitimate part of the project; it would not require you to run autotools first.

lbrynaut commented 6 years ago

@BrannonKing Ok, makes sense. Will it still be self-contained in a single file in the root, or would it need additional structure?

BrannonKing commented 6 years ago

Some people do argue for a CMakeLists.txt file in each subfolder, which is a possible approach. For myself, though, I like to keep it all in one at the parent level; it's easier to navigate that way.

kaykurokawa commented 6 years ago

a small nit, untested but looks good to me.