lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol
https://lbry.com
MIT License
2.58k stars 178 forks source link

support all payment types (P2WPKH, P2WSH, P2SH) as suffixes for our claim OPs #271

Closed BrannonKing closed 5 years ago

BrannonKing commented 5 years ago

When I was testing the claimname RPC implementation with a default TX, the default payment type was P2WSH. This was causing our validation to fail. It shouldn't fail. We should strip the claim prefix from any of the standard payment transaction types; they should all work. For testing, try changing the m_change_type value in the claimname RPC method.

BrannonKing commented 5 years ago

Merged via https://github.com/lbryio/lbrycrd/pull/301