search

lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol
https://lbry.com
MIT License
2.58k stars 178 forks source link

support GCC 8.3 or document that 6 should be used #282

Closed shyba closed 5 years ago

shyba commented 5 years ago

tried and bdb build fails. GCC 6 works error output is huge, but this is repeated all over the place:

../dist/../dbinc/atomic.h:179:19: error: definition of ‘int __atomic_compare_exchange(db_atomic_t*, atomic_value_t, atomic_value_t)’ ambiguates built-in declaration ‘bool __atomic_compare_exchange(long unsigned int, volatile void*, void*, void*, int, int)’
static inline int __atomic_compare_exchange(
                  ^~~~~~~~~~~~~~~~~~~~~~~~~
make: *** [Makefile:2020: cxx_dbc.o] Error 1
lbrynaut commented 5 years ago

Thanks @shyba . The reported issue is specifically for building dependencies, via reproducible build. A known work-around is to run the script as: CC=gcc-6 CXX=g++-6 ./reproducible_build.sh

BrannonKing commented 5 years ago

Saving link: https://patchwork.ozlabs.org/patch/932375/

BrannonKing commented 5 years ago

Yesterday I realized that the "depends" build had this fixed ages ago (in upstream bitcoin which we recently merged). @shyba tested it also and saw no problems.

BrannonKing commented 5 years ago

in master now. (use build.sh or packaging/build_*)