[WIP] Unify and extend rpc methods to bid and sequence

lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol

https://lbry.com

MIT License

2.58k stars 178 forks source link

[WIP] Unify and extend rpc methods to bid and sequence #303

Closed bvbfan closed 5 years ago

bvbfan commented 5 years ago

A bunch of updated rpc keys can lead to breaking changes in users, note it uses camelCase name notation, it can be changed as well. Notable changes: nomalized_name -> normalizedName txid -> txId nHeight -> height nValidAtHeight (valid at height) -> validAtHeight nAmount -> amount nEffectiveAmount (effective amount) -> effectiveAmount total names -> totalNames total claims -> totalClaims total value -> totalValue Most values in getclaimsfortx

bvbfan commented 5 years ago

Changes are breaking since i unify outputs which makes changes to the fields.

BrannonKing commented 5 years ago

The cli help (that shows all the available methods) isn't showing the parameters for the methods in rpc/claimtrie.cpp. It's like the argNames are ignored in that file.