search

lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol
https://lbry.com
MIT License
2.57k stars 178 forks source link

Todo left in help info 0.17.2.1 #306

Closed tiger5226 closed 5 years ago

tiger5226 commented 5 years ago

Todo in help info

supportclaim "name" "claimid" "amount" "value"
Increase the value of a claim. Whichever claim has the greatest value, including all support values, will be the authoritative claim, according to the rest of the rules. The name is the name which is claimed by the claim that will be supported, the txid is the txid of the claim that will be supported, nout is the transaction output which contains the claim to be supported, and amount is the amount which will be added to the value of the claim. If the claim is currently the authoritative claim, this support will go into effect immediately . Otherwise, it will go into effect after 100 blocks. The support will be in effect until it is spent, and will lose its effect when the claim is spent or expires. The amount is a real and is rounded to the nearest .00000001

Arguments:
1. "name"  (string, required) The name claimed by the claim to support.
2. "claimid"  (string, required) The claimid of the claim to support. This can be obtained by TODO PUT IN PLACE THAT SHOWS THIS.
3. "amount"  (numeric, required) The amount in LBC to use to support the claim.
4. "value"  (string, optional) The metadata of the support encoded in hexadecimal.

Result:
"transactionid"  (string) The transaction id of the support.
tiger5226 commented 5 years ago

In addition to this, it would be best if these parameters were optional. Like supporting a name only. would make testing easier.

bvbfan commented 5 years ago

Name + (partial) claimId, which specify a distinct claim, or best one.

tiger5226 commented 5 years ago

Just a name would be best with the option of passing a claimid to make it distinct.

bvbfan commented 5 years ago

https://github.com/lbryio/lbrycrd/pull/303/commits/af9ecd463caa1e51087cc67e426ca55cf0771720 Default amount is the minimum one 0.00000001.

tiger5226 commented 5 years ago

Sweet! @nikooo777 One this is in the release we can take out Chainquery as a dependency of the e2e test.

BrannonKing commented 5 years ago

Merged via https://github.com/lbryio/lbrycrd/pull/303