lbryio / lbrycrd

The blockchain that provides the digital content namespace for the LBRY protocol

https://lbry.com

MIT License

2.57k stars 178 forks source link

Closed BrannonKing closed 4 years ago

BrannonKing commented 4 years ago

and made it work right.

Fixes #383

bvbfan commented 4 years ago

We can unite filter and filter header as well? Do we need separate functions?

BrannonKing commented 4 years ago

Yes, the code is repetitive. Feel free to make a convenient way to pass the column name (and return type) and reuse the code.

BrannonKing commented 4 years ago

Did I mention how pleased I was with the amount of code that I deleted?

bvbfan commented 4 years ago

What was the problem in #383 i can't reproduce it?

BrannonKing commented 4 years ago

383 was a corrupt flat file. I'm not sure how he got one. I'm declaring it fixed by not using the flat file any more.

bvbfan commented 4 years ago

OK, +1 from me, i've test the changes, running test as well.