lbryio / lbrypress

LBRY WordPress plugin
21 stars 7 forks source link

Strikethrough Formatting does not transfer to LBRY Post #32

Open cahlenlee opened 4 years ago

cahlenlee commented 4 years ago

DESCRIPTION: Using Strikethrough formatting in a Wordpress post does not carry over to the LBRY version of the post.


REPRO STEPS: 1) Log into self-hosted Wordpress site w/ LBRYPress Plugin 2) Create a new Post 3) Create a Paragraph Block 4) Enter text and format with Strikethrough 5) Publish and review on LBRY

Results: Strikethrough formatting is missing

Expected: Strikethrough formatting is present


ENVIRONMENT: Ubuntu 18.04.4 WordPress 5.3.3 PHP 7.2.24 LBRYPress 0.0.1 Lodestar Theme 1.0.8


IMAGES:

LBRYPress_0 1 1_TextColorLBRY

LBRYPress_0 1 1_TextColorWordpress


LBRY ADDRESS: bZSqrVdpxt5KJdn2eGMUzT9Jn3gEiRet7b mail@cahlen.org

QuirkyRobots commented 4 years ago

According to the "HTML To Markdown for PHP" documentation,

Markdown Extra, MultiMarkdown and other variants aren't supported – just Markdown.

Which as far as I'm aware doesn't include strikethrough.

In the Elements file, I don't see it registered:

    public function isBlock()
    {
        switch ($this->getTagName()) {
            case 'blockquote':
            case 'body':
            case 'code':
            case 'div':
            case 'h1':
            case 'h2':
            case 'h3':
            case 'h4':
            case 'h5':
            case 'h6':
            case 'hr':
            case 'html':
            case 'li':
            case 'p':
            case 'ol':
            case 'ul':
                return true;
            default:
                return false;
        }
    }

I guess it would have to be added to the converter here?