lbryio / spee.ch

An image hosting service on top of the LBRY protocol.
https://spee.ch
MIT License
185 stars 78 forks source link

Replace Google Analytics Code with Google Tag Manager Code #257

Open QuirkyRobots opened 6 years ago

QuirkyRobots commented 6 years ago

Re: handlebarsHelpers.js - Google Analytics

The Google Analytics (GA) code is best being removed and replaced with Google Tag Manager (GTM).

Google Tag Manager

Google Tag Manager acts as a container you can put your Google Analytics code in, and any other code you want.

This means you can update, add or remove code without touching the site as well as having many more options in the GTM interface.

There are many other benefits for GTM over GA.

Here's some further information about GTM.

10 Reasons to Start Using Google Tag Manager Right Now

Tag Manager Quickstart

How to use Facebook Pixel with GTM...

Facebook Pixel with GTM

finer9 commented 6 years ago

Google Tag Manager is a good idea, agreed. But we dont currently add/remove a lot of tags.

On Thu, Nov 9, 2017 at 10:16 AM, Mark Firth notifications@github.com wrote:

Re: handlebarsHelpers.js https://github.com/lbryio/spee.ch/blob/master/helpers/handlebarsHelpers.js

  • Google Analytics

The Google Analytics (GA) code is best being removed and replaced with Google Tag Manager (GTM).

Google Tag Manager https://tagmanager.google.com/

Google Tag Manager acts as a container you can put your Google Analytics code in, and any other code you want.

This means you can update, add or remove code without touching the site as well as having many more options in the GTM interface.

There are many other benefits for GTM over GA.

Here's some further information about GTM.

10 Reasons to Start Using Google Tag Manager Right Now https://www.lunametrics.com/blog/2017/03/23/10-reasons-start-google-tag-manager/

Tag Manager Quickstart https://developers.google.com/tag-manager/quickstart

How to use Facebook Pixel with GTM...

Facebook Pixel with GTM https://www.facebook.com/business/help/1021909254506499

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lbryio/spee.ch/issues/257, or mute the thread https://github.com/notifications/unsubscribe-auth/APoYDO0BVg3vu7XRw8NQJ87Uvy2X3__9ks5s0xdUgaJpZM4QYICv .

-- Josh Finer COO/LBRY

bones7242 commented 6 years ago

I'll have to read up on GTM but I am interested in making this change. Off the top of my head, I am wondering if it will work with content that gets served directly. I have an npm package that allows me to send analytics directly to GA if needed, and I use that to log 'events' for assets that are served directly.

QuirkyRobots commented 6 years ago

I would think so. It's just a container. Therefor; the GA code remains on the site, but is brought in dynamically. If you need to send analytics directly to GA, this can still be done regardless. :)