search

lbryio / spee.ch

An image hosting service on top of the LBRY protocol.
https://spee.ch
MIT License
185 stars 78 forks source link

Video sharing on Steem #864

Open jsigwart opened 5 years ago

jsigwart commented 5 years ago

Trying to embed a spee.ch video with the social sharing iframe results in Unsupported file type instead of embedding the video:

screen shot 2019-01-08 at 6 50 36 pm
skhameneh commented 5 years ago

That's interesting, very unexpected! Thanks for filing

kauffj commented 5 years ago

@jsigwart could or did you verify that Steem does let you embed other iframe based videos?

tzarebczan commented 5 years ago

Yes, YT iframe links work fine: <iframe width="560" height="315" src="https://www.youtube.com/embed/RA7AjAHg5w0" frameborder="0" allow="accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>

Simply replacing the URL inside produces the same result, so it's not related to the tags.

tzarebczan commented 5 years ago

Ah, think I found the issue...steemit has to whitelist it: https://github.com/steemit/condenser/issues/271

jsigwart commented 5 years ago

@kauffj Yes, I confirmed Steem has a condenser that allows videos from specific sites to be shown, and here is what was done to enable Twitch videos on Steem: https://github.com/steemit/condenser/pull/3088/files

tzarebczan commented 5 years ago

@kodxana has a branch going on https://github.com/kodxana/condenser/commits/master which I reviewed recently. I asked him to fix up / PR it.

jsigwart commented 5 years ago

@kodxana Tom gave you some feedback and said that you need to do the PR with Steemit so they can give additional feedback - can you please give an update on this one?

tzarebczan commented 5 years ago

The pr is here: https://github.com/steemit/condenser/pull/3167

Looks like it's waiting for review. Maybe @kauffj can give someone at steemit a nudge :)

kauffj commented 5 years ago

It shows failing tests. Can we fix those issues before nudging?

jessopb commented 5 years ago

Where are we on this?

alyssaoc commented 5 years ago

@tzarebczan can you update status/next steps