search

lbryio / spee.ch

An image hosting service on top of the LBRY protocol.
https://spee.ch
MIT License
186 stars 77 forks source link

editing claim in a channel fails depending on past navigation #874

Closed jessopb closed 5 years ago

jessopb commented 5 years ago

Reproduce: Go to your own speech channel. navigate into a content item, expand info down, and click on edit. If you do not get an error, click the channel dropdown and select to view your channel again and enter a different content item and try again.

This has something to do with src/client/selectors/show logic causing 'asset' to be undefined, though it initially appears to fail in the DropZone index.js component.

jessopb commented 5 years ago

If, in the URL bar, the url shows @ChannelName:lOngChannelId/claimName, it will fail, but if you reload such that it redirects you to @ChannelName:l/claimName, edit will correctly display for you, as this is what requestId is built from, and requestList[requestId] is looking for one when the other exists.

tzarebczan commented 5 years ago

Ran into this today, we should try to get fixed asap. It's a blank screen if you don't look at the console


    at Function._ [as mapToProps] (bundle.js?7a3d:11)
    at n (bundle.js?7a3d:1)
    at Function.n.mapToProps (bundle.js?7a3d:1)
    at n (bundle.js?7a3d:1)
    at bundle.js?7a3d:1
    at Object.run (bundle.js?7a3d:1)
    at l.u.initSelector (bundle.js?7a3d:1)
    at new l (bundle.js?7a3d:1)
    at Bo (bundle.js?7a3d:48)
    at ua (bundle.js?7a3d:48)
ga @ bundle.js?7a3d:48
r.callback @ bundle.js?7a3d:48
fo @ bundle.js?7a3d:48
co @ bundle.js?7a3d:48
Ii @ bundle.js?7a3d:48
Ai @ bundle.js?7a3d:48
ji @ bundle.js?7a3d:48
Ui @ bundle.js?7a3d:48
Cr @ bundle.js?7a3d:48
bundle.js?7a3d:11 Uncaught TypeError: Cannot read property 'claimData' of undefined
    at Function._ [as mapToProps] (bundle.js?7a3d:11)
    at n (bundle.js?7a3d:1)
    at Function.n.mapToProps (bundle.js?7a3d:1)
    at n (bundle.js?7a3d:1)
    at bundle.js?7a3d:1
    at Object.run (bundle.js?7a3d:1)
    at l.u.initSelector (bundle.js?7a3d:1)
    at new l (bundle.js?7a3d:1)
    at Bo (bundle.js?7a3d:48)
    at ua (bundle.js?7a3d:48)
_ @ bundle.js?7a3d:11
n @ bundle.js?7a3d:1```
tzarebczan commented 5 years ago

Also, when I can actually edit and select a file, it doesn't look like I selected anything - shows the "drag and drop" overlay which can't be clicked anymore. Drag and drop fails sometimes too, or opens the image in the browser (if you drop too quickly I think).

tzarebczan commented 5 years ago

After dragging/dropping, it worked (so maybe something with selection?). But after publishing, it shows the old file. Not sure when all this editing stuff broke :\

Nevermind, I think this last issue might be related to the multiple wallets on spee.ch, I'll check if it happens on others I edit.