search

lbryio / torba

Torba makes it easy to create fast and correct bitcoin based crypto wallets.
MIT License
2.18k stars 20 forks source link

ensure cygwin, win32 and win64 are detected during setup. #62

Closed binaryflesh closed 5 years ago

binaryflesh commented 5 years ago

I use cygwin and several versions of python for testing on windows. distutils.util.get_platform() is the nicest way to catch all three variants. sys.platform get's unknown for cygwin and half right on my windows builds.

codecov[bot] commented 5 years ago

Codecov Report

Merging #62 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #62   +/-   ##
======================================
  Coverage    68.9%   68.9%           
======================================
  Files          64      64           
  Lines       10314   10314           
======================================
  Hits         7107    7107           
  Misses       3207    3207

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9d3e1af...b8136c1. Read the comment docs.

binaryflesh commented 5 years ago

It just now came to me in retrospect, linux end users would then need to have python3x-distutils to be able to install if my PR got accepted. it is a very niche issue that is probably not in best interest. Closing.