search

lbryio / types

Cross-language definitions for standard LBRY types
8 stars 9 forks source link

Determine proper pattern for type-specific metadata #23

Closed kauffj closed 2 years ago

kauffj commented 5 years ago

Recent changes are add new fields like duration which do not apply to all media types (a spreadsheet does not have a duration).

We could easily end up with thousands of metadata properties when we consider type-specific attributes.

What's the correct pattern for this? If it's to define type-specific metadata structures, then it may not be proper to add duration at the top-level for all items.

alyssaoc commented 5 years ago

@lyoshenka what is next for this?

lyoshenka commented 5 years ago

i need to do this eventually

lyoshenka commented 2 years ago

the solution we're going with is to put type-specific fields into their own types

https://github.com/lbryio/types/blob/master/v2/proto/claim.proto#L27