search

lbryio / types

Cross-language definitions for standard LBRY types
8 stars 9 forks source link

Add wallet.json #48

Closed orblivion closed 2 years ago

orblivion commented 2 years ago

One question would be what directory it should go in.

lyoshenka commented 2 years ago

this looks good. you're right that its not clear where this code goes. the whole repo is focused on protobufs. the readme describes how to compile them, and so on.

we're in the process of restructuring our repos a bit, so there's a chance your PR (or even this whole repo) will move elsewhere. i'll merge this for now and move it to a toplevel jsonschema dir

orblivion commented 2 years ago

Cool, just keep in mind that my PR in lbry-sdk depends on the location of the file:

https://github.com/lbryio/lbry-sdk/pull/3572/files#diff-c8a3e8308e908f1b3ec4c3fdf457d082ccc2c21f4c4863b8888c60b296e0a1c8R5

orblivion commented 2 years ago

Oh never mind, you already moved it. I'll update the PR now then.