search

lbuchs / WebAuthn

A simple PHP WebAuthn (FIDO2/Passkey) server library
https://webauthn.lubu.ch
MIT License
419 stars 75 forks source link

Fix JsonSerializable return type (PHP 8.1) #61

Closed BafS closed 2 years ago

BafS commented 2 years ago 
During inheritance of JsonSerializable: Uncaught ErrorException: Return type of lbuchs\WebAuthn\Binary\ByteBuffer::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Fix https://github.com/lbuchs/WebAuthn/issues/52 without breaking changes (it was not fixed yet)

BafS commented 2 years ago

@lbuchs would it be possible to merge this fix? Thanks in advance!

lbuchs commented 2 years ago

Fixed in eab183a7ddbe763c03ca1199e74bfb7c7762f8db

BafS commented 2 years ago

Thank you!

BafS commented 2 years ago

It looks like the package is not auto-updated (https://packagist.org/packages/lbuchs/webauthn#dev-master) so dev-master is not reflecting the last commit. Would it be possible to update it or to tag a new release? Thanks in advance